dheerajturaga commented on code in PR #73746:
URL: https://github.com/apache/airflow/pull/73746#discussion_r4210943106
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -1150,6 +1154,30 @@ def check_cycle(self) -> None:
f"Cycle detected in Dag: {self.dag_id}. Faulty task:
{faulty_task_id}"
)
+ self._warn_task_group_cycles()
+
+ def _warn_task_group_cycles(self) -> None:
Review Comment:
Lang SDKs are out of scope for this PR. It keeps the deprecation to the
Python SDK for 3.4, and dags.rst now says Go, Java and TypeScript SDK Dags are
not checked yet. I've noted on #73678 that Lang SDK Dags need the check on
`SerializedTaskGroup` in core before the 3.5 rejection lands, so the rejection
doesn't end up Python-only.
---
Drafted-by: Claude Code (Opus 5.5); reviewed by @dheerajturaga before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
