ashb commented on a change in pull request #6998: [AIRFLOW-6404] - ANSI color
support for WebUI logger
URL: https://github.com/apache/airflow/pull/6998#discussion_r366299165
##########
File path: airflow/contrib/kubernetes/pod_launcher.py
##########
@@ -122,6 +122,8 @@ def _monitor_pod(self, pod, get_logs):
if get_logs:
logs = self.read_pod_logs(pod)
for line in logs:
+ if isinstance(line, bytes):
+ line = line.decode('utf-8').strip()
Review comment:
Given all this is loop is doing is reading in from one place and writing out
somewhere else it should be fine as binary.
Please explain why this change is needed in more detail. What happened
without it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
