guan404ming commented on code in PR #72786:
URL: https://github.com/apache/airflow/pull/72786#discussion_r4216869395
##########
providers/common/ai/src/airflow/providers/common/ai/toolsets/managed_agent.py:
##########
@@ -245,6 +245,10 @@ def _resolve_agent_ref(self) -> ManagedAgentRef | None:
"""Resolve identity for a log line or a metric tag without letting
resolution fail the call."""
try:
return self.agent_ref
+ except ModelRetry:
Review Comment:
nit: Maybe I'm missing something, but `agent_ref` doesn't seem to raise
`ModelRetry`, and this runs after `invoke()` succeeded, so re-raising would
drop a good answer. Could we drop this branch, or add a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
