schizophrenicmaniac opened a new pull request, #74456: URL: https://github.com/apache/airflow/pull/74456
The "Reproducing task instance heartbeat timeouts locally" section in core-concepts/tasks.rst relies on `[scheduler] task_instance_heartbeat_sec`. Nothing reads that option in Airflow 3: the task-sdk supervisor sends heartbeats on its own schedule, based on `task_instance_heartbeat_timeout` and `[workers] min_heartbeat_interval`. A task sleeping for 600 seconds keeps heartbeating normally and never hits the timeout, so following the steps doesn't do what the docs say. As suggested in the issue, this removes the section. The rest of the "Task Instance Heartbeat Timeout" section, which explains what a heartbeat timeout is and what usually causes one, stays as it is. closes: #74413 --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
