henry3260 commented on code in PR #64523:
URL: https://github.com/apache/airflow/pull/64523#discussion_r4219409039
##########
shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml:
##########
@@ -690,9 +690,22 @@ metrics:
legacy_name: "-"
name_variables: ["status"]
+ - name: "http_requests_total"
+ description: "Number of completed REST API requests, tagged by method,
route, and status_family."
Review Comment:
> So my only other comment here, is if someone is still using a statsd that
doesn't support tagging, this this metric doesn't break out by status, op,
template or anything else.
>
> Without those tags, is it still worthwhile emitting those metrics?
Still worth emitting, I think: the undifferentiated series is what most "is
the API server healthy?" alerts are built on, and every tagged metric in the
registry behaves this way, so gating these two would make them the only metrics
that go silent after an operator sets `statsd_on`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
