kaxil opened a new pull request, #74474:
URL: https://github.com/apache/airflow/pull/74474

   This was embarrasing.
   
   **Before**:
   
   <img width="1153" height="544" alt="image" 
src="https://github.com/user-attachments/assets/a81749a7-4b66-4f50-b6f8-fb26be4f5e75";
 />
   
   ---
   
   The [Quick 
Start](https://airflow.apache.org/docs/apache-airflow/stable/start.html) tells 
users to run `AIRFLOW_VERSION=3.1.1`, so anyone following the 3.3.2 docs 
installs 3.1.1. The pip/WSL block on the same page installs 3.1.0, and the 
example in the note at the top still shows 3.0.0. A few lines below the 3.1.1 
pin, the example URL in a comment renders as `constraints-3.3.2`, because that 
one line kept `|version|`.
   
   The install block declares `:substitutions:` and used 
`AIRFLOW_VERSION=|version|` until #46767 rewrote the guide from pip to uv and 
replaced it with a literal `2.10.5`. The PR does not say why; at the time 
`|version|` on `main` rendered as `3.0.0.dev0`, which has no release to 
install. From then on the pin only moved when someone bumped it by hand 
(#49430, #53770, #57392). The `update-supported-versions` hook and the release 
steps in `dev/README_RELEASE_AIRFLOW.md` rewrite the pins in `README.md` and 
`supported-versions.rst` but do not cover `start.rst`, so it stayed at 3.1.1. 
The WSL block from #57027 hard-coded 3.1.0 from the start.
   
   This uses `|version|` in all three places, the same way 
[`installing-from-pypi.rst`](https://github.com/apache/airflow/blob/main/airflow-core/docs/installation/installing-from-pypi.rst)
 does: `AIRFLOW_VERSION=|version|` in the uv block, `:substitutions:` plus 
`|version|` in the WSL block, and `:subst-code:` for the inline example. 
Release docs then show the release they were built for. On `main`, 
`__version__` is `3.4.0` with no `.dev` suffix, so the page renders `3.4.0`, 
the same as the install examples in `installing-from-pypi.rst`.
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to