Lee-W commented on code in PR #74444:
URL: https://github.com/apache/airflow/pull/74444#discussion_r4227625048
##########
providers/common/ai/docs/agent_security.rst:
##########
@@ -112,7 +112,11 @@ No single layer is sufficient on its own. They work
together.
(``DESCRIBE``/``SHOW``) statements pass; INSERT, UPDATE, DELETE, DROP,
and writes hidden behind ``EXPLAIN`` are rejected.
- Does not prevent the agent from reading sensitive data that the
- database user has SELECT access to.
+ database user has SELECT access to. Without ``allowed_tables`` the
check is
+ statement-level only: a side-effecting function inside a SELECT
+ (``nextval``, ``pg_terminate_backend``, ``dblink_exec``) is not
blocked. Use a
+ least-privilege role, or a read-only transaction where the database
supports
Review Comment:
* The recommendation now pairs a least-privilege role with a read-only
default set on the role or session (`ALTER ROLE <role> SET
default_transaction_read_only = on` on PostgreSQL), and says the toolset opens
its own connection per call so a transaction can't be set from the Dag.
* Dropped the "read-only transaction or session" wording from
`toolsets/sql.rst`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
