SEPURI-SAI-KRISHNA commented on PR #74489:
URL: https://github.com/apache/airflow/pull/74489#issuecomment-6076605910
Thanks for finding this and for the fix. The regression is from #74199,
which is mine, and your diagnosis is right.
I verified `hook_params` round tripped through `serialize()` but used
`{"retry_limit": 7, "retry_delay": 3.5}`, so the input never reached the
serializer's limits. `retry_args` is the one key in that dict whose documented
values are objects, and it is the case I should have used.
The approach looks right to me. Keeping only the JSON serializable values
and warning per dropped key is strictly better than both alternatives: rc1
fails at defer time after the dbt job has already started, and 4.10.0 dropped
every `hook_params` value silently. Falling back to `retry_limit` and
`retry_delay` for the trigger's hook is a sensible floor, and worth having in
the docstring as you did.
The note about `airflow.sdk.serde` replacing `BaseSerialization` in 3.2 is
useful: it explains why this is invisible on older versions, and I had 3.3.2
installed, so my own check would have caught it with the right value.
Happy to review or take any follow-up you would rather hand off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
