ashb commented on code in PR #74349: URL: https://github.com/apache/airflow/pull/74349#discussion_r4233231598
########## airflow-core/src/airflow/ti_deps/deps/loop_archival_dep.py: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.ti_deps.deps.base_ti_dep import BaseTIDep + + +class LoopArchivalDep(BaseTIDep): + """A rerun gate waits for the generated work it replaces to terminate.""" + + NAME = "Loop archival" + IS_TASK_DEP = True + + def _get_dep_statuses(self, ti, dep_context, session): + if ti.waits_for_loop_archival(session=session): + yield self._failing_status(reason="Superseded loop executions are still terminating") Review Comment: I think I can remove this dep entirely actually. I think there's a way this isn't needed at all, as the downstream iterations aren't even _created_ until the previous iteration is over, and as long as we discount/ignore superseded iterations this might work. The best fix is deleteing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
