per-andersen commented on PR #74472: URL: https://github.com/apache/airflow/pull/74472#issuecomment-6087728534
Thanks for the review! Updated: - Added `test_in_process_execution_api_handles_non_ascii_script_name`, which sends a non ASCII `SCRIPT_NAME` through the in-process middleware and checks it arrives intact as the ASGI root_path. It fails without the `SCRIPT_NAME` re-encoding. Note that `InProcessExecutionAPI` itself always passes an empty `SCRIPT_NAME`; the re-encoding matters only if the middleware is mounted under a script name. - The fix is now a small `ASGIMiddleware` subclass instead of a wrapper function, so transport.app remains an `ASGIMiddleware`. The wrapper broke `run_task_instance` in tests_common, which reads transport.app.loop (the test_collect_mapped_task_dag_result failure in CI). - Rebased onto main after #73327 moved `InProcessExecutionAPI` to `in_process.py`; the fix now lives there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
