lokeshlal edited a comment on issue #7160: [AIRFLOW-1467] Dynamic pooling via allowing tasks to use more than one pool slot (depending upon the need) URL: https://github.com/apache/airflow/pull/7160#issuecomment-574255590 > > The other thing you will need to do is add support for this column in to the Serialized DAG format. > > We should add this as an (optional) field in to `airflow/serialization/schema.json` and most things should be handled already. The important thing to test is that the existing "ground truth" dag in `tests/serializtion/test_dag_serialization.py` should have this field set correctly when it is deserializaed without having to update the JSON blob -- that ensures that when upgrading this will behave itself. Please add tests covering that. > > I have added automated test covering this case - so that in the future this should be apparent that you should do it #7162 I have added the pool_slots in schema.json. I will wait for your inputs on #7162 . Just to clarify, the test should create a dag and deserialize the dag and check it against the "ground truth" dict. and pool_slots needs to be added in the ground truth dict as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
