guan404ming opened a new pull request, #74493:
URL: https://github.com/apache/airflow/pull/74493

   ## Related
   
   - Follow-up to 
https://github.com/apache/airflow/pull/71073#discussion_r3763323928
   
   ## Why
   
   - `fail_on_reject` and `ignore_downstream_trigger_rules` lived only on 
`LLMBranchOperator`.
   - `LLMOperator`, `LLMSQLQueryOperator`, `LLMSchemaCompareOperator` and 
`LLMFileAnalysisOperator` always failed on a rejected review, with no opt-out.
   
   ## How
   
   - Move both options and the reject skip onto `LLMOperator`, so every LLM 
approval operator shares them.
   - Keep the defaults: `fail_on_reject=True` on `LLMOperator` and its 
subclasses, `False` on `LLMBranchOperator`.
   - Mark a task as able to skip downstream only when it reviews and 
`fail_on_reject=False`, so the scheduler's skip check stays off for the rest.
   - Return `None` from the SQL and schema-compare resume on a skipping 
rejection instead of validating the rejected output.
   - Update the approval docs.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code Opus 5.5 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to