uranusjr commented on code in PR #68048:
URL: https://github.com/apache/airflow/pull/68048#discussion_r4236753713
##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -1177,15 +1180,16 @@ def _start_driver_status_tracking(self) -> None:
def _poll_k8s_driver_via_api(self) -> str | None:
"""
- Poll the K8s driver pod phase until it reaches a terminal state.
+ Poll the K8s driver container status or pod phase until it reaches a
terminal state.
Returns the terminal phase string (e.g. ``"Succeeded"``) on normal
completion,
or ``None`` if the pod vanished mid-poll (404 — likely deleted by
``on_kill``).
Raises ``RuntimeError`` on failure phases or unrecoverable API errors.
"""
- pod_name = self._kubernetes_driver_pod
+ kubernetes_driver_pod_name = self._kubernetes_driver_pod_name
+ kubernetes_driver_container_name =
self.kubernetes_driver_container_name
Review Comment:
This is a template field, so this can arrive as whitespace from a Jinja
render (not uncommon due to how people indent templates). Maybe do a `strip()`,
or only act against None (instead of falsy) instead below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
