kaxil commented on code in PR #72940:
URL: https://github.com/apache/airflow/pull/72940#discussion_r4237627553
##########
dev/registry/tests/test_extract_versions.py:
##########
@@ -457,3 +457,45 @@ def test_all_missing_returns_empty_dict(self):
result = git_cat_file_batch(tag, paths)
assert result == {}
+
+
+class TestExtractVersionDataToolsetServices:
+ """Same drift-guard as `TestExtractVersionDataConnectionTypes`, for
+ `toolsets.external-services` -- this is the touchpoint memory
+ `reference_registry_connection_field_touchpoints` names as most-missed:
skip it and the
Review Comment:
`reference_registry_connection_field_touchpoints` doesn't exist anywhere in
the repo; it reads like a note from an assistant's memory. Could the docstring
say what breaks instead, e.g. that older versions render from `pv.versionData`,
so dropping the key here empties the card on non-latest pages? "toolsets table"
is also stale now that it's the External Services card.
##########
dev/registry/extract_metadata.py:
##########
@@ -804,6 +805,15 @@ def main():
}
)
+ toolset_services = [
Review Comment:
Toolset items in `provider.yaml.schema.json` only allow `integration-name`
and `python-modules` (`additionalProperties: false`). No provider can declare
`external-services` on a toolset without failing the provider.yaml check, and
common.ai doesn't declare it. #72939 added that schema key, then removed it in
a867f66416 to keep toolsets common.ai-specific.
So `toolset_services` is `[]` for every provider and version, and the card
only shows connection rows. The two new tests use a fixture that the schema
would reject.
I'd drop the toolset half and ship the card for connection types only, which
is the generalized version we talked about. If you want to keep it, the schema
key needs to come back with a reason that answers a867f66416. The comprehension
duplicated in `extract_versions.py` should then move into a shared helper like
`collect_uri_schemes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
