ashb commented on code in PR #74084: URL: https://github.com/apache/airflow/pull/74084#discussion_r4237911201
########## task-sdk/src/airflow/sdk/importers/yaml_importer/migrator.py: ########## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Schema version resolution and forward migration to the head shape. + +A document with an older ``$schema`` is migrated to the head shape by walking +the Cadwyn version bundle and applying each ``VersionChange``'s forward request +converters (`@convert_request_to_next_version_for(DagDocument)`), oldest to +newest. + +Only whole-document request converters keyed on `DagDocument` are applied; a +bundle carrying any other cadwyn instruction is rejected at construction rather +than migrating a document with half its changes applied. (See documentation on +:meth:`DagDocumentMigrator._reject_unsupported_instructions` for rationale.) +""" + +from __future__ import annotations + +import copy +import functools +import re +from typing import TYPE_CHECKING, Any + +import attrs + +from airflow.sdk.importers.yaml_importer.models import DagDocument +from airflow.sdk.importers.yaml_importer.versions import get_bundle + +if TYPE_CHECKING: + from cadwyn import VersionBundle + +_SCHEMA_URL = "https://airflow.apache.org/schemas/dag/{date}.json"; +_VERSION_RE = re.compile(r"\d{4}-\d{2}-\d{2}") + + +def schema_url(date: str) -> str: + """Build the canonical ``$schema`` URL for a published version *date*.""" + return _SCHEMA_URL.format(date=date) + + +def version_from_schema(schema: str) -> str | None: + """Read the version (``YYYY-MM-DD``) token out of a ``$schema`` URL, ignoring the host.""" + match = _VERSION_RE.search(schema or "") Review Comment: Shouldn't this be ```suggestion match = _VERSION_RE.match(schema or "") ``` and/or the _VERSION_RE should be anchored with `^$` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
