uranusjr commented on code in PR #74084: URL: https://github.com/apache/airflow/pull/74084#discussion_r4238704272
########## task-sdk/src/airflow/sdk/importers/yaml_importer/versions/__init__.py: ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Cadwyn `VersionBundle` for the YAML DAG format, keyed by `$schema` version (a dated URL). + +The `cadwyn` import is deferred so importing this package does not pull in +FastAPI/Starlette. Versions are newest-first. +""" + +from __future__ import annotations + +import functools +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + from cadwyn import VersionBundle + + [email protected] +def get_bundle() -> VersionBundle: Review Comment: We already use this naming in exec api and supervisor schema. This is only supposed to be called by the migrator, and IMO the surrounding context (being in the `versions` package) and the return type annotation both make the intention clear enough. We could also rename all usages to say `get_version_bundle` too, but this is probably not the place for it. I’m going to leave this as-is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
