yuseok89 commented on PR #74481: URL: https://github.com/apache/airflow/pull/74481#issuecomment-6114903376
Thanks for the review! 1. Rebased onto the latest main. The migration now sits on top of the current head. 2. `dag_id` was already the leftmost column of `dag_run_dag_id_run_id_key` and `dag_run_dag_id_logical_date_key` before this PR, so the overlap with `idx_dag_run_dag_id` isn't new. Dropping it would be a separate change, so I'd keep this PR to adding the index. I added the MySQL and SQLite results under the query plans in the description. 3. `unique=False` is just the default the migration generator writes, so I'd leave it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
