Andrushika commented on code in PR #74566:
URL: https://github.com/apache/airflow/pull/74566#discussion_r4245482015
##########
.github/workflows/basic-tests.yml:
##########
@@ -152,9 +149,18 @@ jobs:
fi
echo "Installing uv==${UV_VERSION}"
pip install "uv==${UV_VERSION}"
- - name: "Run shared ${{ matrix.shared-distribution }} tests"
- run: uv run --group dev pytest --color=yes -n auto
- working-directory: shared/${{ matrix.shared-distribution }}
+ - name: "Run shared distributions tests"
+ run: |
+ failed=()
+ for dist in ${SHARED_DISTRIBUTIONS}; do
+ echo "::group::Shared ${dist} tests"
+ (cd "shared/${dist}" && uv run --group dev pytest --color=yes -n
auto) || failed+=("${dist}")
Review Comment:
We need "isolation" here. Otherwise, even if a dependency is missing from
`pyproject.toml`, the check can't detect it.
`--exact` removes the packages the current distribution does not declare, so
a missing dependency fails the run again.
```suggestion
(cd "shared/${dist}" && uv run --exact --group dev pytest
--color=yes -n auto) || failed+=("${dist}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
