ehddnr301 commented on code in PR #74552:
URL: https://github.com/apache/airflow/pull/74552#discussion_r4246319791
##########
airflow-core/src/airflow/api_fastapi/common/parameters/dag.py:
##########
@@ -51,6 +59,18 @@
from sqlalchemy.sql import ColumnElement, Select
+class _DagDisplayNamePrefixSearchParam(_PrefixSearchParam):
+ """Match Unicode display-name prefixes without code point bounds that can
disagree with collation order."""
+
+ def _prefix_clause(self, term: str):
+ lower = self._prefix_lower_bound(term)
+ if lower and not lower.isascii():
+ # Keep this fallback scoped to Dag lists; the shared matcher is
tracked in
+ # https://github.com/apache/airflow/issues/74551
Review Comment:
I missed that one, thanks for catching it! I've added the implementation and
test coverage.
If I get a chance to contribute to Airflow again, I'll be a bit more
thorough next time 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
