Andrushika commented on code in PR #74545:
URL: https://github.com/apache/airflow/pull/74545#discussion_r4247471917
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json:
##########
@@ -68,6 +68,17 @@
"upcomingCount_one": "{{count, number}} 個即將到期的期限",
"upcomingCount_other": "{{count, number}} 個即將到期的期限"
},
+ "execution": {
+ "clearSelected": "清除已選取的執行",
+ "empty": "此執行中沒有任何執行項目。",
+ "iteration": "{{node}} · 第 {{index}} 次迭代",
+ "mapped_one": "{{task}}(此頁面有 1 個映射任務)",
+ "mapped_other": "{{task}}(此頁面有 {{count, number}} 個映射任務)",
+ "page": "顯示第 {{start, number}}–{{end, number}} 項,共 {{total, number}} 項執行",
+ "runTasks": "執行任務",
+ "select": "選取 {{task}}",
+ "title": "執行"
+ },
Review Comment:
1. Maybe we can unify on "執行項目" instead of "執行" here? Since we are already
using "執行" for DagRun
2. Since iteration index starts from 0, it could show "第 0 次迭代", maybe "迭代
0"?
(idk this one is kinda weird, no strong opinion on this)
3. "Run tasks" here is a heading (the tasks of this Dag run), so "執行任務" may
read like an action. Maybe "此次 Dag 執行的任務"?
```suggestion
"execution": {
"clearSelected": "清除已選取的執行項目",
"empty": "此次 Dag 執行中沒有任何執行項目。",
"iteration": "{{node}} · 迭代 {{index}}",
"mapped_one": "{{task}}(此頁面有 1 個映射任務)",
"mapped_other": "{{task}}(此頁面有 {{count, number}} 個映射任務)",
"page": "顯示第 {{start, number}}–{{end, number}} 個,共 {{total, number}}
個執行項目",
"runTasks": "此次 Dag 執行的任務",
"select": "選取 {{task}}",
"title": "執行項目"
},
```
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/dag.json:
##########
@@ -68,6 +68,17 @@
"upcomingCount_one": "{{count, number}} 個即將到期的期限",
"upcomingCount_other": "{{count, number}} 個即將到期的期限"
},
+ "execution": {
+ "clearSelected": "清除已選取的執行",
+ "empty": "此執行中沒有任何執行項目。",
+ "iteration": "{{node}} · 第 {{index}} 次迭代",
+ "mapped_one": "{{task}}(此頁面有 1 個映射任務)",
+ "mapped_other": "{{task}}(此頁面有 {{count, number}} 個映射任務)",
+ "page": "顯示第 {{start, number}}–{{end, number}} 項,共 {{total, number}} 項執行",
+ "runTasks": "執行任務",
+ "select": "選取 {{task}}",
+ "title": "執行"
+ },
Review Comment:
1. Maybe we can unify on "執行項目" instead of "執行" here? Since we are already
using "執行" for DagRun
2. Since iteration index starts from 0, it could show "第 0 次迭代", maybe "迭代
0"?
(idk this one is kinda weird, no strong opinion on this)
3. "Run tasks" here is a heading (the tasks of this Dag run), so "執行任務" may
read like an action. Maybe "此次 Dag 執行的任務"?
```suggestion
"execution": {
"clearSelected": "清除已選取的執行項目",
"empty": "此次 Dag 執行中沒有任何執行項目。",
"iteration": "{{node}} · 迭代 {{index}}",
"mapped_one": "{{task}}(此頁面有 1 個映射任務)",
"mapped_other": "{{task}}(此頁面有 {{count, number}} 個映射任務)",
"page": "顯示第 {{start, number}}–{{end, number}} 個,共 {{total, number}}
個執行項目",
"runTasks": "此次 Dag 執行的任務",
"select": "選取 {{task}}",
"title": "執行項目"
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]