larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end-of-file mark and also add an index config for logs URL: https://github.com/apache/airflow/pull/7141#issuecomment-574447922 > @ashb IMO better to split 2 unrelated changes into 2 tickets: > > * add index (good idea) > * fix bug another ticket? > general note: i would like to see test case to proof bug and improve test coverage after this change. The fix for "5528" removed the log_id from the end-of-log mark log record. It broke the end to end scenarios. Because the current elastic search mock does not add log-id to the log records, so it cannot test the end-to-end scenarios where in the real elastic search cluster we rely on the log_id to find the logs for airflow. Since you were the developer who added log_id support, perhaps you can help to update the elastic search mock to add the log id in the log records, so that the scenarios won't be broken in the future, e.g. by another fix along the line of 5528?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
