SameerMesiah97 commented on code in PR #74506: URL: https://github.com/apache/airflow/pull/74506#discussion_r4250714829
########## airflow-core/docs/howto/custom-operator.rst: ########## @@ -24,14 +24,14 @@ Creating a custom Operator Airflow allows you to create new operators to suit the requirements of you or your team. This extensibility is one of the many features which make Apache Airflow powerful. -You can create any operator you want by extending the public SDK base class :class:`~airflow.sdk.BaseOperator`. +You can create your own, custom operator by extending (inheriting from) the public SDK base class :class:`~airflow.sdk.BaseOperator`. Review Comment: ```suggestion You can create your own, custom operator by inheriting from the public SDK base class :class:`~airflow.sdk.BaseOperator`. ``` ########## airflow-core/docs/howto/custom-operator.rst: ########## @@ -24,14 +24,14 @@ Creating a custom Operator Airflow allows you to create new operators to suit the requirements of you or your team. This extensibility is one of the many features which make Apache Airflow powerful. -You can create any operator you want by extending the public SDK base class :class:`~airflow.sdk.BaseOperator`. +You can create your own, custom operator by extending (inheriting from) the public SDK base class :class:`~airflow.sdk.BaseOperator`. -There are two methods that you need to override in a derived class: +There are two methods that you need to override your custom operator: -* Constructor - Define the parameters required for the operator. You only need to specify the arguments specific to your operator. +* Constructor (``__init__``): Define the parameters required for the operator. You only need to specify the arguments specific to your operator. Review Comment: Isn't it self-evident that `__init__` is the constructor? You could just leave it at Constructor or just replace constructor with just `__init__`. Latter would be better to make it consistent with line 34. ########## airflow-core/docs/howto/custom-operator.rst: ########## @@ -24,14 +24,14 @@ Creating a custom Operator Airflow allows you to create new operators to suit the requirements of you or your team. This extensibility is one of the many features which make Apache Airflow powerful. -You can create any operator you want by extending the public SDK base class :class:`~airflow.sdk.BaseOperator`. +You can create your own, custom operator by extending (inheriting from) the public SDK base class :class:`~airflow.sdk.BaseOperator`. -There are two methods that you need to override in a derived class: +There are two methods that you need to override your custom operator: Review Comment: ```suggestion There are two methods that you need to override in your custom operator: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
