kaxil commented on code in PR #74549:
URL: https://github.com/apache/airflow/pull/74549#discussion_r4247995028
##########
.github/workflows/publish-docs-to-s3.yml:
##########
@@ -375,7 +375,12 @@ jobs:
> generated/_build/docs/sphinx-build-skipped.txt
echo "sphinx-build-skipped=true" >> "${GITHUB_OUTPUT}"
else
- breeze build-docs ${SPHINX_INCLUDE_DOCS} --docs-only
${FAIL_ON_INVENTORIES}
+ # Refs whose breeze still has --docs-only check spelling in a
second full build; skip it.
+ DOCS_ONLY=""
+ if grep -q '"--docs-only"'
dev/breeze/src/airflow_breeze/commands/developer_commands.py; then
+ DOCS_ONLY="--docs-only"
+ fi
+ breeze build-docs ${SPHINX_INCLUDE_DOCS} ${DOCS_ONLY}
${FAIL_ON_INVENTORIES}
Review Comment:
It's the `apply-commits` input, set by `breeze workflow-run publish-docs
--apply-commits <sha>,<sha>`.
[`dev/README_RELEASE_AIRFLOW.md`](https://github.com/apache/airflow/blob/270b2abfc258c512a0b931af425904321360d043/dev/README_RELEASE_AIRFLOW.md?plain=1#L749-L761)
documents it for rebuilding an already-released version's docs with doc fixes
cherry-picked on top. Publish has passed `--docs-only` since it was added, so
that patched combination has never been spell-checked anywhere.
Older tags are unaffected, since their breeze still has `--docs-only` and
your grep keeps it. It only applies to tags cut after this PR. For example,
patching a later release's docs with a fix from main whose new word went into
`docs/spelling_wordlist.txt` in a separate commit would now fail the publish
instead of shipping. That's rare, and the fix is to cherry-pick the wordlist
commit too, so I'm fine leaving it as is. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
