amoghrajesh commented on code in PR #73889:
URL: https://github.com/apache/airflow/pull/73889#discussion_r4248284746
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
@@ -2802,6 +2802,28 @@ def
test_schedule_tis_preserves_allocated_attempt(dag_maker, session, state, try
assert session.get(TI, ti_id).try_number == try_number
+def test_schedule_tis_clears_retry_policy_columns(dag_maker, session):
+ """The new try must not inherit the finished try's reason."""
+ with dag_maker(session=session) as dag:
+ BashOperator(task_id="task", bash_command="echo 1")
+ dr = dag_maker.create_dagrun(session=session)
+ ti = dr.get_task_instance("task", session=session)
+ ti.refresh_from_task(dag.get_task("task"))
+ ti.state = None
Review Comment:
Agreed. Seeded both columns in test_schedule_tis_preserves_allocated_attempt
so all three states are covered, and dropped the standalone test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
