vatsrahul1001 opened a new pull request, #74624: URL: https://github.com/apache/airflow/pull/74624
The `breeze verify` command (added in #73241) derives the base ref and the selective-checks `default_branch` from `branch_defaults.AIRFLOW_BRANCH`. Its tests in `test_verify_commands.py`, however, hardcode `"main"`. On `main` that's fine, but on a `vX-Y-test` release branch — where `AIRFLOW_BRANCH` is e.g. `"v3-4-test"` — three things shift and **8 tests fail**: - `find_default_base_ref()` looks for `<remote>/v3-4-test` instead of `<remote>/main`; - the no-apache-remote fallback (`base_ref = AIRFLOW_BRANCH`) is `v3-4-test`, not `main`; - `default_branch=AIRFLOW_BRANCH` passed to selective checks changes the docs list (e.g. `build-docs apache-airflow docker-stack`). `v3-4-test` is the first release branch to fast-forward in this command, so it's the first to surface it (patch branches like `v3-3-test` only get cherry-picks and don't have the command yet). The fix pins `AIRFLOW_BRANCH` / `DEFAULT_AIRFLOW_CONSTRAINTS_BRANCH` to `main` / `constraints-main` in an autouse fixture, so the suite asserts the `main` behaviour it was written for regardless of which branch it runs on. Verified: the previously-failing 8 tests pass on `v3-4-test` (real `AIRFLOW_BRANCH="v3-4-test"`), and all 23 still pass on `main`. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 4.8) Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
