eladkal commented on code in PR #74623: URL: https://github.com/apache/airflow/pull/74623#discussion_r4255668036
########## providers/smtp/docs/utils/legacy.rst: ########## Review Comment: I don't think we need that. The plan should be simple - copy all related items to provider after release deprecate all items in core and set them to read from provider while verifying min version of the provider in core. ########## providers/smtp/src/airflow/providers/smtp/utils/legacy.py: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Transport compatibility for callers that resolve legacy email settings.""" + +from __future__ import annotations + +import logging +import smtplib +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + import ssl + from collections.abc import Callable + from email.mime.multipart import MIMEMultipart + +log = logging.getLogger(__name__) + + +def send_mime_email( Review Comment: We already have that in smtp provider utils don't we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
