kacpermuda commented on code in PR #73655:
URL: https://github.com/apache/airflow/pull/73655#discussion_r4256478747
##########
providers/openlineage/src/airflow/providers/openlineage/utils/sql_hook_lineage.py:
##########
@@ -194,7 +194,7 @@ def _get_namespace(hook_id: int) -> str | None:
events.extend(
_create_ol_event_pair(
task_instance=task_instance,
-
job_name=f"{task_instance.dag_id}.{task_instance.task_id}.query.{query_count}",
+
job_name=f"{task_instance.dag_id}.{task_instance.task_id}.hll_query.{query_count}",
Review Comment:
We need some kind of differentiation between events emitted by hook level
lineage from those emitted by the ol methods on the operator. We do a similar
thing
[here](https://github.com/apache/airflow/blob/main/providers/openlineage/src/airflow/providers/openlineage/api/sql.py#L180)
in the api method, where we put `manual_query`. Imho having `manual_query` for
manual calls, `hll_query` for hook level lineage and `query` for native
implementations makes sense (also given that when calling api method manually
one can specify their own job name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
