pankajastro commented on code in PR #74228:
URL: https://github.com/apache/airflow/pull/74228#discussion_r4248314883
##########
providers/common/sql/src/airflow/providers/common/sql/datafusion/object_storage_provider.py:
##########
@@ -102,19 +103,52 @@ def create_object_store(self, path: str,
connection_config: ConnectionConfig | N
if temp_key_path is not None:
Path(temp_key_path).unlink(missing_ok=True)
- def get_scheme(self) -> str:
- """Return the scheme for GCS."""
- return "gs://"
+
+# Host suffix matched loosely (not pinned to dfs.core.windows.net) to also
cover sovereign
+# clouds, consistent with DataFusionEngine._resolve_wasb_account's
AZURE_STORAGE_ENDPOINT tolerance.
+_ABFS_URI_RE =
re.compile(r"^abfss?://(?P<container>[^@/]+)@(?P<account>[^./]+)\.[^/]+(?P<path>/.*)?$")
Review Comment:
Fixed in b63272c. The URI host now follows the same rule as the connection
host: it must be a `*.core.windows.net host`, or
`AZURE_STORAGE_ENDPOINT/AZURE_ENDPOINT` must be set. Otherwise raise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
