pankajkoti commented on code in PR #74473:
URL: https://github.com/apache/airflow/pull/74473#discussion_r4257951222
##########
providers/common/ai/src/airflow/providers/common/ai/mixins/hitl_review.py:
##########
@@ -285,8 +284,5 @@ def regenerate_with_feedback(self, *, feedback: str,
message_history: Any) -> tu
@staticmethod
def _to_string(output: Any) -> str:
- if isinstance(output, BaseModel):
- return output.model_dump_json()
- if not isinstance(output, str):
- return str(output)
- return output
+ """Serialize an output for review as JSON, or ``str()`` when pydantic
cannot."""
+ return dump_output_to_json(output)
Review Comment:
THanks, Kaxil, addressed in the latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
