olayiwola-gbenga opened a new pull request, #74664:
URL: https://github.com/apache/airflow/pull/74664
`CloudFirestoreExportDatabaseOperator` previously waited synchronously in
the worker process and unconditionally submitted a new export request on every
task execution. If a worker was interrupted or restarted while an export was
running in Google Cloud, the subsequent Airflow retry failed with `HttpError
400` because the original operation was still in progress or had already
written export metadata to the target Cloud Storage `outputUriPrefix`.
Long-running exports also occupied a worker slot for the entire duration of the
operation.
This change:
- Adds `reattach_on_restart=True` (default) to
`CloudFirestoreExportDatabaseOperator` and
`CloudFirestoreHook.export_documents` / `start_export_documents` to reattach to
an in-progress export operation or skip submitting a duplicate export when a
matching operation for the same `outputUriPrefix`, `collectionIds`, and
`namespaceIds` has already completed.
- Adds `deferrable` mode (`CloudFirestoreAsyncHook` and
`CloudFirestoreExportDatabaseTrigger`) so long-running Firestore exports can be
polled asynchronously by the Triggerer without holding a worker slot.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
