kaxil commented on PR #70433:
URL: https://github.com/apache/airflow/pull/70433#issuecomment-6159062314
Thanks @ColtenOuO. We want this in common.ai 1.0.0rc1, so I rebased it onto
main, made some changes while resolving the conflicts, and pushed a follow-up
commit. Your commit keeps your authorship.
Changes beyond the rebase:
- The return direction @gopidesupavan asked for: `bytes` results that are
valid UTF-8 come back as text, anything else as `{"base64": ...}`.
- The base64 check also runs in the args validator, so an
`approval_required()` toolset doesn't use up its one approval on a call that
gets refused later.
- Annotations go through `get_type_hints` one at a time. Substituting `Any`
for a missing name crashed `get_tools` with an `AttributeError` on annotations
like `pd.DataFrame`.
- I dropped `contentEncoding` and kept the note in the description. The
reason is in the updated PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
