hussein-awala commented on code in PR #74243:
URL: https://github.com/apache/airflow/pull/74243#discussion_r4270431810
##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -811,7 +817,12 @@ def _cleanup_table(
)
logger.debug("old rows query:\n%s", query.selectable.compile())
print(f"Checking table {orm_model.name}")
- num_rows = _check_for_rows(session=session, query=query, print_rows=False)
+ num_rows = _check_for_rows(
+ session=session,
+ query=query,
+ table_name=orm_model.name,
+ print_rows=False,
+ )
Review Comment:
Nit: could we pass `_format_table_name(orm_model.schema, orm_model.name)`
here instead of `orm_model.name`?
For a schema-qualified table such as `audit.log`, the new count message
currently says `Found 5 rows in table log...`, while the deletion messages say
`Performing Delete from audit.log...`. Using the formatted name would keep
table attribution consistent throughout the progress output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
