Lee-W commented on code in PR #74695:
URL: https://github.com/apache/airflow/pull/74695#discussion_r4273149206
##########
providers/common/ai/src/airflow/providers/common/ai/toolsets/sql.py:
##########
@@ -369,7 +379,11 @@ def _is_ref_allowed(self, catalog: str | None, schema: str
| None, table: str) -
@property
def id(self) -> str:
- return f"sql-{self._db_conn_id}"
+ suffix = f"-{self._tool_prefix}" if self._tool_prefix else ""
+ return f"sql-{self._db_conn_id}{suffix}"
+
+ def _tool_name(self, base: str) -> str:
Review Comment:
`SQLToolset` and `DataFusionToolset` now override `tool_name_conflict_hint`
to tell users to pass `tool_prefix=...`, and to say that wrapping the toolset
in `PrefixedToolset` renames only the tools. `HookToolset` and `MCPToolset` are
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
