RehanAhmad25 commented on code in PR #74539:
URL: https://github.com/apache/airflow/pull/74539#discussion_r4273785588
##########
providers/microsoft/mssql/src/airflow/providers/microsoft/mssql/hooks/mssql.py:
##########
@@ -110,16 +173,57 @@ def get_conn(self) -> PymssqlConnection:
**extra_conn_args,
)
- def set_autocommit(
- self,
- conn: PymssqlConnection,
- autocommit: bool,
- ) -> None:
- conn.autocommit(autocommit)
+ def _get_mssql_python_conn(self) -> Any:
+ """Return ``mssql_python`` connection object."""
+ try:
+ mssql_python = import_module("mssql_python")
+ except ImportError as e:
+ raise ImportError(
Review Comment:
You're right, I should have done that from the start. Switched to
`AirflowOptionalProviderFeatureException` and updated the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
