ashb commented on code in PR #74752:
URL: https://github.com/apache/airflow/pull/74752#discussion_r4277074953


##########
providers/openlineage/src/airflow/providers/openlineage/facets/AirflowRunFacet.json:
##########
@@ -196,6 +196,14 @@
         "map_index": {
           "type": "integer"
         },
+        "loop_index": {
+          "description": "Zero-based iteration of the loop the task runs in. 
Absent outside a loop.",
+          "type": "integer"
+        },
+        "loop_max_iterations": {
+          "description": "Maximum number of iterations of the loop the task 
runs in. Absent outside a loop.",
+          "type": "integer"
+        },

Review Comment:
   Just having `loop_index` will mean this needs to change if/when nested loops 
are allowed in Airflow.
   
   It also doesn't support mapped tasks inside a loop, which is supported 
today. This is why Airflow has a "dynamic_region" concept.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to