Andrushika commented on code in PR #74715:
URL: https://github.com/apache/airflow/pull/74715#discussion_r4269885372
##########
Dockerfile.ci:
##########
@@ -1824,14 +1824,14 @@ RUN SYSTEM=$(uname -s | tr '[:upper:]' '[:lower:]') \
&& chmod +x /usr/local/bin/helm
# Install mprocs - a modern process manager for managing multiple Airflow
components
-ARG MPROCS_VERSION="0.9.6"
+ARG MPROCS_VERSION="0.10.2"
Review Comment:
We might need to keep `q` as a one-key quit here.
With `0.10.2`, when users press `q` on their keyboard in `breeze
start-airflow`, it opens dekit's quit menu instead of quitting, so the "press
q" steps in our docs no longer match.
##########
Dockerfile.ci:
##########
@@ -1824,14 +1824,14 @@ RUN SYSTEM=$(uname -s | tr '[:upper:]' '[:lower:]') \
&& chmod +x /usr/local/bin/helm
# Install mprocs - a modern process manager for managing multiple Airflow
components
-ARG MPROCS_VERSION="0.9.6"
+ARG MPROCS_VERSION="0.10.2"
RUN SYSTEM=$(uname -s | tr '[:upper:]' '[:lower:]') \
&& PLATFORM="$(uname -m)" \
- &&
MPROCS_URL="https://github.com/pvolok/mprocs/releases/download/v${MPROCS_VERSION}/mprocs-${MPROCS_VERSION}-${SYSTEM}-${PLATFORM}-musl.tar.gz";
\
+ &&
MPROCS_URL="https://github.com/pvolok/dekit/releases/download/v${MPROCS_VERSION}/dekit-${PLATFORM}-unknown-${SYSTEM}-musl.tar.gz";
\
Review Comment:
Nit: we might also point `upgrade_important_versions.py` at `pvolok/dekit`.
It still asks `pvolok/mprocs` and only works through GitHub's rename redirect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
