kaxil commented on code in PR #74768:
URL: https://github.com/apache/airflow/pull/74768#discussion_r4283117690
##########
dev/breeze/tests/test_verification_plan.py:
##########
@@ -79,6 +79,18 @@ def test_each_flag_maps_to_its_commands(flag: str):
assert commands == [command for _, command, _ in FLAG_COMMANDS[flag]]
+def test_agent_framework_commands_cover_every_framework_in_the_ci_matrix():
+ workflow = AIRFLOW_ROOT_PATH / ".github" / "workflows" /
"agent-framework-tests.yml"
+ matrix =
yaml.safe_load(workflow.read_text())["jobs"]["tests"]["strategy"]["matrix"]["framework"]
+
+ frameworks = [
+ shlex.split(shlex.split(command)[-1])[-1]
+ for _, command, _ in FLAG_COMMANDS["run_agent_framework_tests"]
+ ]
+
+ assert frameworks == matrix
Review Comment:
Good point, applied in 60c878be989. I used `sorted()` rather than `set()` so
a framework listed twice on one side still fails the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
