kaxil commented on code in PR #74735:
URL: https://github.com/apache/airflow/pull/74735#discussion_r4283246612
##########
providers/common/ai/tests/unit/common/ai/operators/test_agent.py:
##########
@@ -1474,19 +1450,20 @@ def
test_code_mode_capability_turns_off_tool_approval(self, fake_harness, capabi
def test_harness_without_the_code_mode_extra_does_not_break_other_agents(
self, harness_without_code_mode_extra
):
- # Neither the durable check at construction nor the approval check at
run time may
- # touch the harness root, whose CodeMode export would raise
ImportError here.
- AgentOperator(task_id="t", prompt="p", llm_conn_id="llm",
durable=True, capabilities=[Thinking()])
+ # The approval check at run time must not touch the harness root,
whose CodeMode
+ # export would raise ImportError here.
op = AgentOperator(task_id="u", prompt="p", llm_conn_id="llm",
capabilities=[Thinking()])
assert op._supports_tool_approval() is True
+ @pytest.mark.skipif(not AIRFLOW_V_3_3_PLUS, reason="Per-tool approval
needs Airflow >= 3.3")
def test_capability_function_is_left_for_the_run_to_resolve(self,
fake_harness):
Review Comment:
Not deliberate, thanks. Split it in 9583d595a94:
`test_capability_function_is_left_for_the_run_to_resolve` has `durable=True`
again and runs on every Airflow version, and the `_supports_tool_approval()`
assertion is now its own 3.3+ test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
