kaxil commented on code in PR #74737: URL: https://github.com/apache/airflow/pull/74737#discussion_r4283251665
########## providers/common/ai/docs/approval_gates.rst: ########## @@ -21,15 +21,145 @@ Approval gates for LLM operators ================================ .. seealso:: - This page covers the one-shot approve, edit or reject gate on ``LLMOperator`` and its - subclasses. For a multi-round review loop on ``AgentOperator`` with a chat UI and REST - API, see :doc:`hitl_review`. + For a multi-round review loop on ``AgentOperator`` with a chat UI and REST API, see + :doc:`hitl_review`. -Set ``require_approval=True`` to pause the task after the LLM generates its -output and wait for a human reviewer to approve or reject it via the Airflow -HITL interface. Optionally allow the reviewer to edit the output before -approving with ``allow_modifications=True``, and set a deadline with -``approval_timeout``. +Set ``require_approval=True`` and the task stops after the model answers. A person +reads the output in the Airflow UI and approves it, edits it, or rejects it, and only an +approved answer reaches the tasks downstream. Use it where a wrong answer is costly to +publish or act on. To review each tool call an agent makes rather than its final answer, +see :doc:`tool_approval`. + +Approval gates need Airflow 3.1 or later. On an older Airflow version the +operator raises ``AirflowOptionalProviderFeatureException: require_approval=True needs Airflow 3.1+.`` +when it is constructed, so the Dag file +fails to import, and with it every Dag defined in that file. A dynamically mapped Review Comment: Applied in e3fc608bda4. I built the docs and checked the rendered page: both paragraphs read as before apart from the two new full stops, and the link to "What each answer does" still resolves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
