vatsrahul1001 commented on code in PR #74840: URL: https://github.com/apache/airflow/pull/74840#discussion_r4293859782
########## airflow-core/newsfragments/74840.bugfix.rst: ########## @@ -0,0 +1 @@ +Redact values of camelCase and PascalCase keys (for example ``privateKey``, ``connectionString`` or ``webhookUrl``) that match multi-word sensitive field names such as ``private_key``, ``connection_string`` or ``webhook_url``. Review Comment: Nit: this is labelled `bugfix`, but it also means more keys get hidden than before (including some ordinary-looking ones, see my comment on `secrets_masker.py`). Worth saying that explicitly, or checking whether the project wants a different label for this kind of change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
