tomron commented on code in PR #74755:
URL: https://github.com/apache/airflow/pull/74755#discussion_r4294211255
##########
airflow-core/src/airflow/api_fastapi/execution_api/versions/__init__.py:
##########
@@ -77,6 +78,7 @@
AddArgBindingsToTIRunContext,
AddCallbackRunEndpoint,
AddDagRunNoteUpdateEndpoint,
+ AddExecutionTimeoutToTIRunContext,
Review Comment:
Thanks. Moving to 2027-02-28 is my preference, but on the supervisor-schema
side it has a knock-on effect I'd like to check first.
A new 2027-02-28 supervisor-schema version moves `schema.json`'s
`api_version`, and the `sync-go-sdk-schemas` / `sync-ts-sdk-schemas` hooks keep
the Go and TS vendored copies identical to it. So both SDKs would also have to
declare supervisor schema 2027-02-28 (`SupervisorSchemaVersion`,
`capabilities.yaml`, the generated TS constant), which means SDK builds from
main would need an Airflow release newer than 3.4.
Is that acceptable, or would you rather keep 2026-10-30 and backport to
v3-4-test before 3.4.0? I have the 2027-02-28 move ready locally and can push
either way. The other three comments are addressed in 5454b4fe76, and the PR
body now spells out the SIGTERM timing and the native Dag task coverage.
---
Drafted-by: Claude Code (Opus 5.5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
