vatsrahul1001 commented on code in PR #74837:
URL: https://github.com/apache/airflow/pull/74837#discussion_r4294515512
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py:
##########
@@ -452,7 +452,8 @@ def enqueue_connection_test(
else:
effective_team = test_body.team_name
- auth_method: ResourceMethod = "PUT" if existing is not None and
test_body.commit_on_success else "POST"
+ commit_allows_update = existing is not None and test_body.commit_on_success
Review Comment:
Does this still let a queued test overwrite a newer edit when
`commit_allows_update` is true? E.g. A queues the test, B edits the connection,
then A's test passes and commits over B's change.
If that's out of scope for 3.4.0, maybe say so in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
