kadubhumika commented on code in PR #74916:
URL: https://github.com/apache/airflow/pull/74916#discussion_r4302541199
##########
providers/google/src/airflow/providers/google/cloud/hooks/dataproc.py:
##########
@@ -26,7 +26,7 @@
from collections.abc import MutableSequence, Sequence
Review Comment:
Hi @shahar1 , thank you for reviewing my PR!
I've addressed your feedback:
- Removed the unrelated Dataproc commits (my branch was created from the
wrong
base). The PR now contains only the teardown change.
- Added the how-to docs in setup-and-teardown.rst.
- Added task-sdk tests for the new argument.
- Fixed the CI failures: renamed the newsfragment to the PR number, synced
the
Go/Java/TypeScript schema copies, and excluded the teardown-only flag from
the
Go/Java/TS SDK generators, the same way on_failure_fail_dagrun is excluded.
- Fixed the title and added the AI disclosure to the PR description.
Could you please review again when you have time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
