justinpakzad opened a new pull request, #74922:
URL: https://github.com/apache/airflow/pull/74922
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
The serde timezone serializer can't handle timezones that are just a fixed
offset with no name. The datetime serializer saves an empty place holder and
reading the value back (e.g., via Xcom pull) fails. Take the following dag:
```python3
from datetime import datetime
from airflow.sdk import dag, task
@dag
def serde_offset_tz():
@task
def push_offset():
return datetime.fromisoformat("2024-01-01T00:00:00+02:00")
@task
def do_something(value):
print(repr(value), value.utcoffset())
do_something(push_offset())
serde_offset_tz()
```
On main, `do_something` would fail with: `ValueError: ZoneInfo keys must be
normalized relative paths, got:`
This PR adds support for timezones with a fixed, nonzero UTC offset and no
name, by encoding them as a pendulum `FixedTimezone`. Additional tests were
added to cover the new behavior. The `NoNameTZ` helper now returns `None` from
utcoffset so that `test_timezone_serialize_no_name` still covers the fallback
path (no name or fixed offset).
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (Claude Sonnet 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
