fat-catTW commented on code in PR #74890:
URL: https://github.com/apache/airflow/pull/74890#discussion_r4303231334
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/dag_run.py:
##########
@@ -486,11 +486,12 @@ def handle_bulk_update(
continue
dag_id, run_id = key
dag_run = dag_run_map[key]
+ # Apply "note" before "state" so listeners fired inside
patch_dag_run_state() see the updated note.
+ if entity.note is not None:
Review Comment:
Thanks for the PR.
Maybe we should resolve the Dag before updating its note when `state` is
set?
If `get_dag_for_run()` raises 404, the bulk handler catches it and the
request still commits the new note even though the state update failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
