prabhnoor0212 commented on code in PR #74776: URL: https://github.com/apache/airflow/pull/74776#discussion_r4303505011
########## providers/openlineage/src/airflow/providers/openlineage/utils/utils.py: ########## @@ -2242,8 +2242,9 @@ def get_filtered_unknown_operator_keys(operator: BaseOperator) -> dict: def should_use_external_connection(hook) -> bool: - # If we're at Airflow 2.10, the execution is process-isolated, so we can safely run those again. - return True + from airflow.providers.openlineage import conf + + return conf.sql_use_external_connection() Review Comment: `get_openlineage_facets_with_sql` in `openlineage/sqlparser.py` now checks `should_use_external_connection()` too, so operators going through the shared helper (such as MySQLToGCSOperator) honor sql_use_external_connection=False. An explicit use_connection=False from a caller is still respected: the effective value is use_connection and should_use_external_connection(hook) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
