potiuk commented on code in PR #74904:
URL: https://github.com/apache/airflow/pull/74904#discussion_r4304653517
##########
providers/common/ai/provider.yaml:
##########
@@ -202,6 +202,7 @@ connection-types:
- Pydantic AI Gateway
- SambaNova
- Snowflake Cortex
+ - System One servers
Review Comment:
`test_no_declared_vendor_is_absent_upstream` fails: `system-one:` only
exists from pydantic-ai 2.53.0 (as the decision-model example notes), while
`uv.lock` has 2.48.0 and `ALL_DECLARED_VENDORS_AVAILABLE_FROM` is 2.45.0, so
the vendor list can't claim it yet. Suggest dropping it until the lock moves to
>=2.53, then adding it back with a `LABELS` entry and a raised
`ALL_DECLARED_VENDORS_AVAILABLE_FROM`. `decision_models.rst` still documents
the prefix.
```suggestion
```
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
##########
providers/common/ai/docs/supported_services.rst:
##########
@@ -54,13 +55,16 @@ Toolsets
- Object storage (S3, GCS, Azure Blob Storage, or any store
:class:`~airflow.sdk.ObjectStoragePath` can open), read-only
* - :doc:`SandboxToolset <sandbox/index>`
- - Docker Sandboxes (the shipped sbx backend; other backends can be added
via SandboxBackend)
+ - Modal, Islo, OpenSandbox, OpenShell, Boat and Docker Sandboxes (sbx),
through the
+ shipped :doc:`backends <sandbox/backends>`; other services can be added
with a
Review Comment:
`test_toolset_table_entries_match_supported_services_rst` allows exactly one
`:doc:` target per toolset row, so the inline link to `sandbox/backends` fails
it. The row already links `sandbox/index`, which leads to the backends page.
```suggestion
shipped backends; other services can be added with a
```
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
##########
providers/common/ai/src/airflow/providers/common/ai/get_provider_info.py:
##########
@@ -175,6 +175,7 @@ def get_provider_info():
"Pydantic AI Gateway",
"SambaNova",
"Snowflake Cortex",
+ "System One servers",
Review Comment:
The regenerated copy of the `provider.yaml` line above.
```suggestion
```
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
