This is an automated email from the ASF dual-hosted git repository.
shahar1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new fd4654dce4f Fall back for empty console domain (#70067)
fd4654dce4f is described below
commit fd4654dce4fc33be0ab35249043c8c0a71202cf2
Author: suyua9 <[email protected]>
AuthorDate: Sun Oct 18 13:56:32 2026 +0800
Fall back for empty console domain (#70067)
---
.../airflow/providers/google/common/hooks/base_google.py | 3 ++-
.../tests/unit/google/common/hooks/test_base_google.py | 16 ++++++++++++++++
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git
a/providers/google/src/airflow/providers/google/common/hooks/base_google.py
b/providers/google/src/airflow/providers/google/common/hooks/base_google.py
index ab54f1ad6ee..83538c3ea2c 100644
--- a/providers/google/src/airflow/providers/google/common/hooks/base_google.py
+++ b/providers/google/src/airflow/providers/google/common/hooks/base_google.py
@@ -436,7 +436,8 @@ class GoogleBaseHook(BaseHook):
@staticmethod
def get_high_value_cookie_domain() -> str:
- return os.getenv("GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN", "google.com")
+ domain = os.getenv("GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN")
+ return "google.com" if domain in (None, "") else domain
def get_client_options(
self,
diff --git
a/providers/google/tests/unit/google/common/hooks/test_base_google.py
b/providers/google/tests/unit/google/common/hooks/test_base_google.py
index 8170fc45fa4..b324f70e9d9 100644
--- a/providers/google/tests/unit/google/common/hooks/test_base_google.py
+++ b/providers/google/tests/unit/google/common/hooks/test_base_google.py
@@ -865,6 +865,22 @@ class TestGoogleBaseHook:
assert is_default_universe
+ @pytest.mark.parametrize(
+ ("high_value_cookie_domain", "expected_result"),
+ [
+ pytest.param(None, "google.com", id="unset_value"),
+ pytest.param("", "google.com", id="empty_value"),
+ pytest.param("googleapis.cn", "googleapis.cn", id="custom_value"),
+ ],
+ )
+ def test_get_high_value_cookie_domain(self, high_value_cookie_domain,
expected_result):
+ env = {}
+ if high_value_cookie_domain is not None:
+ env["GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN"] =
high_value_cookie_domain
+
+ with patch.dict(os.environ, env, clear=True):
+ assert self.instance.get_high_value_cookie_domain() ==
expected_result
+
def test_get_client_options_default(self):
with patch.dict(os.environ, {}, clear=True):
client_options = self.instance.get_client_options()
