henry3260 commented on code in PR #71654:
URL: https://github.com/apache/airflow/pull/71654#discussion_r4305954170
##########
airflow-core/src/airflow/api_fastapi/common/parameters/range.py:
##########
@@ -151,10 +166,10 @@ def to_orm(self, select: Select) -> Select:
if self.value.lower_bound_gte:
x = self.value.lower_bound_gte
- select = select.where(or_(self.attribute >= x,
self.attribute.is_(None)))
+ select = select.where(or_(self.attribute >= x,
self._get_null_lower_bound_clause()))
if self.value.lower_bound_gt:
x = self.value.lower_bound_gt
- select = select.where(or_(self.attribute > x,
self.attribute.is_(None)))
+ select = select.where(or_(self.attribute > x,
self._get_null_lower_bound_clause()))
Review Comment:
This `lower_bound_gt` branch changed too, but nothing exercises it with a
`null_lower_bound_clause`: the new unit test passes` lower_bound_gt=None`, and
the new route test only sends start_date_gte. The existing `start_date_gt`
cases at test_dag_run.py:819/:919 all use runs with a non-NULL start_date, so
they never reach the NULL branch. Could we add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
