vatsrahul1001 commented on code in PR #74839:
URL: https://github.com/apache/airflow/pull/74839#discussion_r4306171245
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:
##########
@@ -719,19 +720,20 @@ def get_dag_asset_queued_event(
responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
dependencies=[
Depends(requires_access_asset(method="DELETE")),
- Depends(requires_access_dag(method="PUT")),
Depends(action_logging()),
],
)
def delete_asset_queued_events(
asset_id: int,
- readable_dags_filter: ReadableDagsFilterDep,
+ editable_dags_filter: EditableDagsFilterDep,
Review Comment:
Optional: before this change a user with no editable Dags was rejected by
`requires_access_dag(method="PUT")` with a 403. Now the route falls through to
a 404 when nothing editable matches. That is probably fine, but it is a status
change for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
